engineering: fix cache extraction failure in win32 node_modules cache#293358
Closed
Copilot wants to merge 2 commits intojoao/turquoise-tahrfrom
Closed
engineering: fix cache extraction failure in win32 node_modules cache#293358Copilot wants to merge 2 commits intojoao/turquoise-tahrfrom
Copilot wants to merge 2 commits intojoao/turquoise-tahrfrom
Conversation
The tar extraction was failing when the cache directory existed but the cache.tzst file didn't (e.g., after cache key change). Added a Test-Path check to only attempt extraction if the file exists. Co-authored-by: joaomoreno <22350+joaomoreno@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update Windows node_modules caching to tar+zstd
engineering: fix cache extraction failure in win32 node_modules cache
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt after #291624 and revert #291740
When the cache key changes (e.g., cache salt update), the cache restore step creates
.build/node_modules_cache/but withoutcache.tzstinside. The extraction step then fails trying to extract a non-existent file:Changes:
Test-Pathcheck before tar extraction in Azure Pipelines win32 compile stepTest-Pathcheck before tar extraction in GitHub Actions pr-win32-test workflowThis makes cache extraction resilient to cache key changes without requiring manual cache invalidation.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.